Make Mapper Methods in Services private

core/src/main/java/studentmanagement/service/course/CourseService.java

@@ -21,8 +21,4 @@ public interface CourseService extends Service<Course> {
     List<CourseStudentListDto> findAllMappedToDto();
 
     List<CourseStudentListDto> findAllSortedByNameMappedToDto();
-
-    CourseIdNameDto courseToCourseIdNameDto(Course course); // TODO Remove these methods. Make them Private
-
-    CourseStudentListDto courseToCourseStudentListDto(Course course);
 }

core/src/main/java/studentmanagement/service/course/DefaultCourseService.java

@@ -76,13 +76,11 @@ public class DefaultCourseService extends DefaultService<Course> implements Cour
         return courseMapper.courseUpsertRequestToCourse(request);
     }
 
-    @Override
-    public CourseIdNameDto courseToCourseIdNameDto(Course course) {
+    private CourseIdNameDto courseToCourseIdNameDto(Course course) {
         return courseMapper.courseToCourseIdNameDto(course);
     }
 
-    @Override
-    public CourseStudentListDto courseToCourseStudentListDto(Course course) {
+    private CourseStudentListDto courseToCourseStudentListDto(Course course) {
         return courseMapper.courseToCourseStudentListDto(course);
     }
 }
\ No newline at end of file

core/src/main/java/studentmanagement/service/student/DefaultStudentService.java

@@ -57,13 +57,11 @@ public class DefaultStudentService extends DefaultService<Student> implements St
         return studentMapper.studentUpsertRequestToStudent(request);
     }
 
-    @Override
-    public StudentIdNameDto studentToStudentIdNameDto(Student student) {
+    private StudentIdNameDto studentToStudentIdNameDto(Student student) {
         return studentMapper.studentToStudentIdNameDto(student);
     }
 
-    @Override
-    public StudentCreateResponse studentToStudentCreateResponse(Student student) {
+    private StudentCreateResponse studentToStudentCreateResponse(Student student) {
         return studentMapper.studentToStudentCreateResponse(student);
     }
 }

core/src/main/java/studentmanagement/service/student/StudentService.java

@@ -18,8 +18,4 @@ public interface StudentService extends Service<Student> {
     StudentIdNameDto findByIdMappedToDto(IDableKey studentKey);
 
     List<StudentIdNameDto> findAllMappedToDto();
-
-    StudentIdNameDto studentToStudentIdNameDto(Student student);
-
-    StudentCreateResponse studentToStudentCreateResponse(Student student);
 }

core/src/main/java/studentmanagement/service/teacher/DefaultTeacherService.java

@@ -58,13 +58,11 @@ public class DefaultTeacherService extends DefaultService<Teacher> implements Te
         return teacherMapper.teacherUpsertRequestToTeacher(request);
     }
 
-    @Override
-    public TeacherIdNameDto teacherToTeacherIdNameDto(Teacher teacher) {
+    private TeacherIdNameDto teacherToTeacherIdNameDto(Teacher teacher) {
         return teacherMapper.teacherToTeacherIdNameDto(teacher);
     }
 
-    @Override
-    public TeacherCreateResponse teacherToTeacherCreateResponse(Teacher teacher) {
+    private TeacherCreateResponse teacherToTeacherCreateResponse(Teacher teacher) {
         return teacherMapper.teacherToTeacherCreateResponse(teacher);
     }
 }

core/src/main/java/studentmanagement/service/teacher/TeacherService.java

@@ -18,8 +18,4 @@ public interface TeacherService extends Service<Teacher> {
     TeacherIdNameDto findByIdMappedToDto(IDableKey teacherKey);
 
     List<TeacherIdNameDto> findAllMappedToDto();
-
-    TeacherIdNameDto teacherToTeacherIdNameDto(Teacher teacher);
-
-    TeacherCreateResponse teacherToTeacherCreateResponse(Teacher teacher);
 }